Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ENR Everywhere #682

Merged
merged 10 commits into from
Dec 6, 2024
Merged

Use ENR Everywhere #682

merged 10 commits into from
Dec 6, 2024

Conversation

ScottyPoi
Copy link
Collaborator

@ScottyPoi ScottyPoi commented Dec 6, 2024 •
edited
Loading

Refactors message handling to pass whole ENR downstream instead of INodeAddress / NodeId

By preserving the whole ENR, we eliminate the need to lookup ENR's based on NodeId.

This also solves issues in uTP transfers with peers not in the routing table.

acolytec3
acolytec3 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 59d6d98 into master Dec 6, 2024
4 of 5 checks passed
@acolytec3 acolytec3 deleted the use-ENR-everywhere branch December 6, 2024 02:44
@ScottyPoi ScottyPoi mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @acolytec3