Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fragment for Deferred Topic Filter #4682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukastanisic99
Copy link

Subscribing with contract.filter.EventName(someValue...) returns the entire log object instead of returning the Event arguments to the listener. Other checks bellow check if fragment is present in the event but since it's an 'else if' it never triggers.

Subscribing with contract.filter.EventName(someValue...) returns the entire log object instead of returning the Event arguments to the listener.
Other checks bellow check if fragment is present in the event but since it's an 'else if' it never triggers.
@lukastanisic99
Copy link
Author

When you take a look at what's invoked when using the Deferred Topic Filter

return new PreparedTopicFilter(contract, getFragment(...args), args);

It also expects an Event Fragment and the typechain types that are generated also expect Event arguments instead of the full log object.
Taking all that into account it seems there is no 'design decision' not to include the fragment as part of the Deferred Topic Filter, so the PR is a fix to an intended and expected behavior.

@ricmoo ricmoo added investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 next-patch Issues scheduled for the next arch release. and removed next-patch Issues scheduled for the next arch release. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants