Do not increment NonceManager delta if transaction send fails #4811
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return await this.signer.sendTransaction(tx); | ||
| return await this.signer.sendTransaction(tx); | ||
| } catch (err) { | ||
| this.#delta--; |
There was a problem hiding this comment.
If the error happens in getNonce, we shouldn't reduce #delta.
There was a problem hiding this comment.
Ignore previous comment. The noncePromise is awaited after we increment, so we should always decrease upon error.
|
Related discussion: #972 |
|
I don't agree with this comment. #972 (comment) If the documentation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sendTransaction call fails for any reason like your node/provider going down, subsequent calls to sendTransaction will fail until the user manually calls reset in their catch clause wrapping sendTransaction which I would assume not many people do.
Automatically handling this would save people lots of headache and outages.