Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pro 305 integrate layer zero/stargate protocol #138

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lbw33
Copy link
Contributor

@lbw33 lbw33 commented Jul 10, 2023

Description

  • Amended StargateFacet contract to handle new changes in logic. Updated and added an ETH transfer function that is a new feature that Stargate has enabled.
  • Removed some logic from the old contract as it can be handled by backend (pool ids).
  • Test suite updated and amended for new iteration of contract.

Motivation and Context

  • To update the StargateFacet contract to comply with latest Stargate changes and to add new functionality.

How Has This Been Tested?

  • Test suite (see screenshots).

Screenshots (if appropriate):

Screen Shot 2023-07-10 at 16 36 14

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@linear
Copy link

linear bot commented Jul 10, 2023

PRO-305 Etherspot to integrate LayerZero/Stargate protocol

Integrate LayerZero/Stargate protocol to Etherspot's cross-chain aggregation solution

More information: https://layerzero.gitbook.io/docs/guides/master/how-to-send-a-message

Documentation and example code: https://stargateprotocol.gitbook.io/stargate/

@lbw33
Copy link
Contributor Author

lbw33 commented Jul 12, 2023

There is one test that is commented out which is not working correctly that I am currently in discussion with Stargate on how to solve. Rather than hold up the PR for this I will amend this test separately when the problem has been debugged.

SGReceiver.sol is part of this test to check the logic executes correctly on receiving chain.

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants