Feature/wallet connect 2.0 #236
Conversation
| @@ -196,6 +203,10 @@ export class Sdk { | |||
| constructor(walletProvider: WalletProviderLike, optionsLike?: EnvNames | SdkOptions) { | |||
| let options: SdkOptions = {}; | |||
|
|
|||
| if (isWalletConnectProvider(walletProvider)) { | |||
There was a problem hiding this comment.
this lets to avoid any additional mappings before passing Wallet Connect provider to Etherspot SDK constructor
| @@ -17,7 +17,8 @@ | |||
| "ES5", | |||
| "es2015.collection", | |||
| "es2015.iterable" | |||
| ] | |||
| ], | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
skips types check on node_modules
| try { | ||
| const { | ||
| accounts: [address], | ||
| chainId, | ||
| } = provider; | ||
|
|
||
| this.setAddress(address); | ||
| this.setNetworkName(chainId); | ||
| } catch (err) { | ||
| // | ||
| } |
There was a problem hiding this comment.
Just out of curiosity is there a reason we're using try / catch here as if accounts / chainId are not found in provider it would just return undefined for the destrucutred vartiables?
There was a problem hiding this comment.
this is copy paste implementation of previous Wallet Connect provider
| const response = await this.provider.signer.request({ | ||
| method: 'personal_sign', | ||
| params: [toHex(message), this.address], | ||
| }); |
There was a problem hiding this comment.
Just wondering if htis could return an error from the await?
There was a problem hiding this comment.
this is copy paste implementation of previous Wallet Connect provider, it can return error, but it wasn't handled in previous Wallet Connect provider so didn't feel to add anything extra that is beyond previous structure
| ({ | ||
| accounts: [address], | ||
| chainId, | ||
| } = payload.params[0]); |
There was a problem hiding this comment.
This is definitely valid due to the [0]
|
@vignesha22 @marie-fourier Pls review this |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes