Consolidation, withdrawal & exit request creation tool #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test instructions:
participants_matrix:
el:
- el_type: geth
el_image: ethpandaops/geth:lightclient-prague-devnet-4-37035c5
- el_type: reth
el_image: ethpandaops/reth:onbjerg-devnet-4-8a40d5c
cl:
- cl_type: lighthouse
cl_image: ethpandaops/lighthouse:pawan-electra-alpha7-0dd215c
- cl_type: prysm
cl_image: ethpandaops/prysm-beacon-chain:develop-4aa5410
vc_image: ethpandaops/prysm-validator:develop-4aa5410
network_params:
electra_fork_epoch: 1
min_validator_withdrawability_delay: 1
shard_committee_period: 1
churn_limit_quotient: 16
seconds_per_slot: 6
additional_services:
- dora
- assertoor
snooper_enabled: true
assertoor_params:
image: "ethpandaops/assertoor:electra-support-456ffe4"
run_stability_check: false
run_block_proposal_check: false
tests:
- { file: "https://raw.githubusercontent.com/ethpandaops/assertoor/refs/heads/master/playbooks/dev/fund-wallet.yaml", config: { targetAddress: "0x332E43696A505EF45b9319973785F837ce5267b9" } }
- { file: "https://raw.githubusercontent.com/ethpandaops/assertoor/refs/heads/electra-support/playbooks/pectra-dev/kurtosis/bls-changes.yaml", config: { targetAddress: "0x332E43696A505EF45b9319973785F837ce5267b9" } }change the address (
|
pk910
changed the title
pk910
changed the title
skylenet
reviewed
Nov 5, 2024
| // https://eips.ethereum.org/EIPS/eip-7251#fee-calculation | ||
| let i = 1n; | ||
| let output = 0n; | ||
| let numeratorAccum = 1n * 17n; // factor * denominator |
There was a problem hiding this comment.
Maybe worth to just create a const/var for this 17? It's from CONSOLIDATION_REQUEST_FEE_UPDATE_FRACTION right? Ideally we would probably read it from config, but it can get annoying passing that to the UI code.
| // https://eips.ethereum.org/EIPS/eip-7002#fee-calculation | ||
| let i = 1n; | ||
| let output = 0n; | ||
| let numeratorAccum = 1n * 17n; // factor * denominator |
There was a problem hiding this comment.
Same as previous comment. 17 could be something hardcoded or from config as WITHDRAWAL_REQUEST_FEE_UPDATE_FRACTION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a submit consolidations and a submit withdrawals page, that can be used to create & submit consolidation, withdrawal & exit transactions.
These pages are intended to be available for testnets only. Therefore they are disabled by default and need to be enabled via the
frontend.showSubmitElRequestssetting if wanted.Submit Consolidation Requests:
Submit Withdrawal/Exit Requests:
