Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for op-deployer, fix multiple L2s #74

Merged
merged 24 commits into from
Sep 25, 2024
Merged

feat: Add support for op-deployer, fix multiple L2s #74

merged 24 commits into from
Sep 25, 2024

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Sep 20, 2024 •
edited
Loading

@mslipper mslipper changed the title Add support for op-deployer, fix multiple L2s feat: Add support for op-deployer, fix multiple L2s Sep 20, 2024
@mslipper mslipper marked this pull request as ready for review September 21, 2024 05:05
@barnabasbusa
Copy link
Contributor

From a very quick look, it seems like "manual deployment" of the contract is no longer possible.
I might presume incorrectly but don't you ever wanna check that the manual contract deployment still working as expected? I understand that you would default to a contract being part of the genesis file, but feel like if you disable the functionality on contract deployment altogether then it's also going to be one more thing to test in case there is a change on L1.

@mslipper
Copy link
Collaborator Author

mslipper commented Sep 23, 2024 •
edited
Loading

Hey! I'm not sure what you mean by manual deployment of the contracts. The contracts are deployed using regular transactions to the L1 in the enclave, they're just all deployed upfront before spinning up the L2s. They're not injected into the L1's genesis file.

barnabasbusa
barnabasbusa reviewed Sep 23, 2024
View reviewed changes
src/package_io/input_parser.star Outdated Show resolved Hide resolved
src/wait/wait_for_sync.star Outdated Show resolved Hide resolved
src/package_io/sanity_check.star Show resolved Hide resolved
src/participant_network.star Show resolved Hide resolved
@barnabasbusa barnabasbusa enabled auto-merge (squash) September 25, 2024 19:15
@barnabasbusa barnabasbusa linked an issue Sep 25, 2024 that may be closed by this pull request
Deploying L2 contracts is super slow and makes for bad devex #68
Closed
@barnabasbusa barnabasbusa merged commit eb59380 into main Sep 25, 2024
5 checks passed
@barnabasbusa barnabasbusa deleted the feat/op-deployer-support branch September 25, 2024 19:28
@EthPandaOpsBot EthPandaOpsBot mentioned this pull request Sep 25, 2024
Open
@barnabasbusa barnabasbusa mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnabasbusa barnabasbusa barnabasbusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying L2 contracts is super slow and makes for bad devex
2 participants
@mslipper @barnabasbusa