This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
Fix send id #5
Open
Fix send id #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should caller ever be responsible for setting id? |
|
@moodysalem It's because web3js pub sub likes to generate its own IDs for sendAsync actions so it knows which message is the rpc response. It's a weird use-case, but it's needed. |
| ): Promise< | ||
| | JsonRpcSucessfulResponseMessage<TResult> | ||
| | JsonRpcErrorResponseMessage<TErrorData> | ||
| > { | ||
| const id = getUniqueId(); | ||
| const id = Number.isNaN(optionalId as any) |
There was a problem hiding this comment.
Here we should check for undefined values, if optionalId value is undefined then id will be undefined too
|
This fix solve an issue that I have when send rpc messages from my app (inside iframe) to metamask: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
sendAsync, thepayloadparameter may contain an existing objectid. I've added a check for if the id is set and to use it instead of generating a new id.