Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests quick fix: tests/ops/models/test_connectionconfig.py #5672

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Tests quick fix: tests/ops/models/test_connectionconfig.py #5672

merged 1 commit into from
Jan 15, 2025

Conversation

andres-torres-marroquin
Copy link
Contributor

Description Of Changes

Tests quick fix: tests/ops/models/test_connectionconfig.py

Code Changes

tests/ops/models/test_connectionconfig.py has updated to fix tests.

Steps to Confirm

  1. See the CI pipeline pass.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jan 15, 2025 8:12pm

@cypress Cypress
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11786

Run Properties:  status check passed Passed #11786  •  git commit 3f550e2fc3 ℹ️: Merge 72dbcdd2a39b929c26cf7eb6460352546eaad906 into 72cd9b3fb1b5886767458b060bdd...
Project fides
Branch Review refs/pull/5672/merge
Run status status check passed Passed #11786
Run duration 01m 03s
Commit git commit 3f550e2fc3 ℹ️: Merge 72dbcdd2a39b929c26cf7eb6460352546eaad906 into 72cd9b3fb1b5886767458b060bdd...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@andres-torres-marroquin andres-torres-marroquin merged commit b3cb8d0 into main Jan 15, 2025
36 of 37 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/tests-quick-fix branch January 15, 2025 20:51
@cypress Cypress
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11790

Run Properties:  status check passed Passed #11790  •  git commit b3cb8d0e73: Tests quick fix: tests/ops/models/test_connectionconfig.py (#5672)
Project fides
Branch Review main
Run status status check passed Passed #11790
Run duration 01m 00s
Commit git commit b3cb8d0e73: Tests quick fix: tests/ops/models/test_connectionconfig.py (#5672)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @eastandwestwind