bump external-datastores job timeout from 20 to 30 min
#5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
andres-torres-marroquin
approved these changes
Jan 16, 2025
adamsachs
added
the
run unsafe ci checks
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5677/merge
|
| Run status |
|
| Run duration | 00m 58s |
| Commit |
|
| Committer | Adam Sachs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
merging even without confirmation on this branch that it solves the problem, since this is a very low risk change - and in the interest of time. |
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 59s |
| Commit |
|
| Committer | Adam Sachs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unticketed
Description Of Changes
external-datastoresjob is timing out onmain,possibly due to the GH runner upgrades to python 3.12 (since we now have to install python manually?)-- this seems unlikely upon further investigation, more likely is we added tests to increase the runtime of the job but it hadn't been running for a few days due to the python upgrade issue, so that increase in timing was being obfuscated.at least as a temporary measure, we can bump the timeout to hopefully avoid the timeout and get this job passing again
Code Changes
external-datastoresjob from 20 to 30 minSteps to Confirm
let's see how the job does on CI on this PRnevermind, forgot to put therun unsafe ci checkslabel on soexternal-datastoreswas skipped. let's just get this merged and test it onmain, it's a very low risk change 👍Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works