Make cuckoo_time_translator depend on rosconsole_bridge #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesSommer
force-pushed
the
fix/useConsoleBridgeProperly
branch
from
3457e1f to
33c833d
Compare
This should redirect the console_bridge logging from the algorithms to the rosconsole.
This seems to be necessary. It is wrong to do it in this library. But the right thing would probably be to do it in rosconsole_bridge itself.
HannesSommer
force-pushed
the
fix/useConsoleBridgeProperly
branch
from
33c833d to
06e1372
Compare
|
Okay this seems to work now after this additional fix. It is just not documented what one really needs to do (i.e. using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should redirect the console_bridge logging from the algorithms to
the rosconsole.
@marco-tranzatto , this should solve the logging issue for the filters :). Can you easily test it? It could be that it does not work transitively. I.e. if that isn't enough probably the driver actually needs to depend on
rosconsole_bridge