Improving external feature interface and documentation #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smauq
commented
Mar 21, 2023
•
smauq
commented
- Added new sensor to EuRoC config
- Removed maplab_features as a default dependency as it will unnecessarily pull in unwanted packages if not desired. Instead will add a link in the ReadMe and a wiki page detailing the separate installation here Updating the wiki #375
- Updated some interfaces in aslam
- Fixed a few return value conversions from aslam functions with descriptor types that were causing unnecessary copies to happen
- Added an outlier rejection filter to the matches provided by external keypoint tracking
|
Test PASSed. |
|
Multiple failed Jenkins builds are due to Github's RSA key changing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.