Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer: Use bash, add bashrc #90

Conversation

marcojob
Copy link
Contributor

@marcojob marcojob commented Dec 6, 2024

Description

Specifies bash as console and adds the bashrc file. This adds a lot of convenient console features such as tab completion and colors

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Other (please describe): Vscode devcontainer convenience

Detailed Summary

  • On user creation, specify bash as console
  • Copy the skeleton .bashrc to the home folder of the created user

The only thing I don't fully understand is why the .bashrc is not copied automatically, but this can happen if the base image is a very minimal image

@victorreijgwart
Copy link
Member

Thanks for this PR @marcojob! The changes look good to me. I'll import it into the main repo so that all the CI jobs can run, and then merge it to main.

@victorreijgwart victorreijgwart changed the base branch from main to feature/better_devcontainer December 10, 2024 12:30
@victorreijgwart victorreijgwart merged commit f43f604 into ethz-asl:feature/better_devcontainer Dec 10, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants