Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cat-features-dl-models into master #344

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

egoriyaa
Copy link
Collaborator

@egoriyaa egoriyaa commented May 27, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

egoriyaa and others added 3 commits May 22, 2024 10:08
* add working with categoricals in RNN

* update changelog

* fix tests

* add test on MultiEmbedding, write comments

* remove numeric columns that are also categorical

* fix docs

---------

Co-authored-by: Egor Baturin <[email protected]>
* add handling categorical features in MLP and DeepAR Native

* update changelog

* fix

* lints

* fix mlp tests

* fix

---------

Co-authored-by: Egor Baturin <[email protected]>
* cat

* add embeddings to deepstate

* update changelog

* minor fixes for other models

---------

Co-authored-by: Egor Baturin <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented May 27, 2024

🚀 Deployed on https://deploy-preview-344--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 27, 2024 18:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 27, 2024 22:34 Inactive
@egoriyaa egoriyaa self-assigned this May 27, 2024
@github-actions github-actions bot temporarily deployed to pull request May 27, 2024 22:41 Inactive
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 136 lines in your changes are missing coverage. Please review.

Project coverage is 9.75%. Comparing base (2b1544a) to head (12580e3).
Report is 1 commits behind head on master.

Files Patch % Lines
etna/models/nn/deepstate/deepstate.py 0.00% 38 Missing ⚠️
etna/models/nn/rnn.py 0.00% 33 Missing ⚠️
etna/models/nn/deepar_native/deepar.py 0.00% 31 Missing ⚠️
etna/models/nn/mlp.py 0.00% 25 Missing ⚠️
etna/models/nn/utils.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #344       +/-   ##
==========================================
- Coverage   88.83%   9.75%   -79.09%     
==========================================
  Files         224     224               
  Lines       15259   15360      +101     
==========================================
- Hits        13556    1498    -12058     
- Misses       1703   13862    +12159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egoriyaa egoriyaa requested a review from d-a-bunin May 28, 2024 07:02
@egoriyaa egoriyaa merged commit 4ba2c0e into master May 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants