Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeepStateModel forecasting problem with horizon=1 #377

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Conversation

ostreech1997
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #338 .

Copy link

github-actions bot commented Jun 3, 2024

🚀 Deployed on https://deploy-preview-377--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 3, 2024 08:51 Inactive
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 9.74%. Comparing base (2b1544a) to head (1a0b371).
Report is 4 commits behind head on master.

Current head 1a0b371 differs from pull request most recent head 5925430

Please upload reports for the commit 5925430 to get more accurate results.

Files Patch % Lines
etna/models/nn/deepstate/state_space_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #377       +/-   ##
==========================================
- Coverage   88.83%   9.74%   -79.10%     
==========================================
  Files         224     224               
  Lines       15259   15372      +113     
==========================================
- Hits        13556    1498    -12058     
- Misses       1703   13874    +12171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-a-bunin d-a-bunin self-requested a review June 3, 2024 10:26
@github-actions github-actions bot temporarily deployed to pull request June 3, 2024 11:57 Inactive
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot temporarily deployed to pull request June 3, 2024 12:04 Inactive
@d-a-bunin d-a-bunin merged commit 5cb8485 into master Jun 3, 2024
14 checks passed
@d-a-bunin d-a-bunin deleted the issue-338 branch June 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DeepStateModel doesn't forecast with horizon=1
2 participants