[BUG] Forecast visualization with horizon=1
#426
Conversation
|
Visualisation with horizon=1 
|
|
🚀 Deployed on https://deploy-preview-426--etna-docs.netlify.app |
| @@ -182,7 +189,7 @@ def plot_forecast( | |||
| segment_borders_df.index.values, | |||
| values_low, | |||
| values_high, | |||
| facecolor=forecast_color, | |||
| color=forecast_color, | |||
| alpha=alpha[interval_idx], | |||
There was a problem hiding this comment.
Because of these alphas fillings become transparent and it is not seen.
We need to discuss how to calculate them
There was a problem hiding this comment.
What was the logic of calculating current alpha?
There was a problem hiding this comment.
Could you explain or provide an example when filling is not seen?
Current logic is based on the ability to support nested intervals. So, if we plot them, we can easily see them at different levels of transparancy.
For example
How this will look in case, when we have intervals ? |
I said that they were not seen before and are not seen now because fillings are transparent. We need to discuss it |
|
Results:
2. With intervals
3. With one interval
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=========================================
- Coverage 9.61% 9.51% -0.10%
=========================================
Files 226 227 +1
Lines 15594 15757 +163
=========================================
Hits 1500 1500
- Misses 14094 14257 +163 ☔ View full report in Codecov by Sentry. |
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #303