Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add **kwargs argument description for models #454

Merged
merged 20 commits into from
Aug 26, 2024

Conversation

ArtemLiA
Copy link

@ArtemLiA ArtemLiA commented Aug 13, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Add **kwargs argument description for CatBoostMultiSegmentModel, CatBoostPerSegmentModel, ElasticMultiSegmentModel, ElasticPerSegmentModel, LinearMultiSegmentModel, LinearPerSegmentModel.

Closing issues

Closes #445

ArtemLiA and others added 19 commits June 22, 2024 01:55
1) Wrap step param into double `` in the AutoRegressivePipeline docs.
2) Fix problem with linting.
3) Add a link to the pull request in the CHANGELOG.md
1) Add space between "Autocorrelation function" and (ACF, pho(t)) and the same for PACF.
2) Add a link to the pull request in the CHANGELOG.md
* Fix links in 'See Also' references in `Pipeline` docs
* Fix links in 'See Also' references in `AutoRegressivePipeline` docs
* Fix links in 'See Also' references in `DirectEnsemble` docs
@ArtemLiA ArtemLiA changed the title Add kwargs argument description for models Add **kwargs argument description for models Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (1f74446) to head (de42274).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         229      229           
  Lines       15935    15935           
=======================================
  Hits        14407    14407           
  Misses       1528     1528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-a-bunin d-a-bunin self-requested a review August 23, 2024 12:23
etna/models/catboost.py Outdated Show resolved Hide resolved
etna/models/linear.py Outdated Show resolved Hide resolved
etna/models/linear.py Outdated Show resolved Hide resolved
* Add external links to `CatBoostRegressor` in `CatBoostMultiSegmentModel` and
  `CatBoostPerSegment` docs.

* Add external links to `LinearRegression` in `LinearMultiSegmentModel`
  and `LinearPerSegmentModel` docs.

* Add external links to `ElasticNet` in `ElasticMultiSegmentModel` and
  `ElasticPerSegmentModel` docs.
@d-a-bunin d-a-bunin merged commit e5cc8d6 into etna-team:master Aug 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add **kwargs param description for models
2 participants