Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to load pretrained embedding models #461

Merged
merged 18 commits into from
Aug 30, 2024
Merged

Conversation

egoriyaa
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #452

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Aug 27, 2024

🚀 Deployed on https://deploy-preview-461--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 16:12 Inactive
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.44%. Comparing base (b19507d) to head (d2f2da9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
etna/transforms/embeddings/models/ts2vec.py 96.15% 1 Missing ⚠️
etna/transforms/embeddings/models/tstcc.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   90.41%   90.44%   +0.03%     
==========================================
  Files         229      229              
  Lines       15939    15988      +49     
==========================================
+ Hits        14411    14461      +50     
+ Misses       1528     1527       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egoriyaa egoriyaa self-assigned this Aug 28, 2024
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 07:57 Inactive
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/tstcc.py Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 11:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 11:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 07:54 Inactive
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Outdated Show resolved Hide resolved
etna/transforms/embeddings/models/ts2vec.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 10:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 10:57 Inactive
@@ -24,7 +24,8 @@
" * [Baseline](#section_2_1)\n",
Copy link
Collaborator

@d-a-bunin d-a-bunin Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.    ts.df_exog = None

Looks strange... Can we avoid doing this?

dE.g. we can recreate tsdataset using to_pandas. I just think it isn't good to show users they can change df_exog this way.


Reply via ReviewNB

@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 15:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 29, 2024 15:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 30, 2024 08:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 30, 2024 08:35 Inactive
@egoriyaa egoriyaa merged commit b3a48c3 into master Aug 30, 2024
17 checks passed
@d-a-bunin d-a-bunin deleted the issue-452 branch September 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to load pretrained embedding models
2 participants