Unlock experimental tests #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-464--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 90.44% 90.62% +0.17%
==========================================
Files 229 247 +18
Lines 15989 16481 +492
==========================================
+ Hits 14462 14936 +474
- Misses 1527 1545 +18 ☔ View full report in Codecov by Sentry. |
brsnw250
reviewed
Sep 2, 2024
| @@ -215,17 +215,6 @@ def test_valid_params_sampling(product_level_constant_hierarchical_ts, pipeline) | |||
| assert_sampling_is_valid(intervals_pipeline=intervals_pipeline, ts=product_level_constant_hierarchical_ts) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
Why this test was removed ?
There was a problem hiding this comment.
Because in #432 we added implementation for params_to_tune, so this doesn't raise NotImplementedError anymore.
There was a problem hiding this comment.
I think it is better to rewrite this test with the stub, since it is the only test for ensembles params_to_tune
brsnw250
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Unlock experimental tests
Closing issues