Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading CSV in commands #470

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

fuglaeff
Copy link

@fuglaeff fuglaeff commented Sep 4, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #468

@fuglaeff fuglaeff changed the title Issue 468 Fix reading CSV in commands Sep 4, 2024
@fuglaeff
Copy link
Author

fuglaeff commented Sep 4, 2024

I looked at the project code and it seems that these are the only weak points.

@d-a-bunin d-a-bunin self-requested a review September 4, 2024 08:36
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (72ab4dd) to head (29d7c13).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         247      247           
  Lines       16481    16481           
=======================================
  Hits        14933    14933           
  Misses       1548     1548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
etna/commands/backtest_command.py Show resolved Hide resolved
etna/commands/forecast_command.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fuglaeff
Copy link
Author

fuglaeff commented Sep 4, 2024

Looked at my mistakes in the tests and fixed them

d-a-bunin
d-a-bunin previously approved these changes Sep 5, 2024
@d-a-bunin d-a-bunin merged commit 1526e36 into etna-team:master Sep 5, 2024
16 checks passed
@fuglaeff fuglaeff deleted the issue-468 branch September 5, 2024 11:13
@fuglaeff fuglaeff restored the issue-468 branch September 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Remove leading zeros from segment names when using forecast command
2 participants