Refactoring java

.vscode/settings.json

@@ -0,0 +1,10 @@
+{
+    "java.checkstyle.configuration": "${workspaceFolder}\\src\\checkstyle.xml",
+    "files.exclude": {
+        "**/*.class": true
+    },
+    "java.checkstyle.version": "10.17.0",
+    "files.watcherExclude": {
+        "**/*.class": true
+    }
+}

README.md

@@ -12,10 +12,44 @@ Reason how you have been thinking and the decisions you took.
 You can hand in the result any way you feel (git patch, pull-request or ZIP-file).
 Note: the Git history must be included.
 
+## Solution 
+Below are the steps on my thought process, the reasoning behind it is 
+pretty standard for a refactoring process: 
+Make it work, Make it beautiful and organized, Then make it fast.
 
+1. Understand the code 
+	- It's a Movie rental statement generator for Customers.
+	Contains classes organized by Customer, Movie, MovieRental,
+	RentalInfo.
+2. Understand and list the issues in the codebase.
+    - Unreadable
+	- Tests are not properly organized
+	- Classes are unorganized
+	- Not using SOLID principles
+	- Not using best practices
+	- Not using production grade ecosystem
+	- Other potential improvements: Code smells, Linting, Improve speed/performance
+
+3. Iterate on fixing the issues so that the codebase will be 
+production grade.
+
+
+## More refactoring ideas
+
+   - Better robust error handling using exceptions
+   - More comprehensive test cases
+   - Functional Programming idioms (not necessary)
+   - Spring boot
+
+
+## To run mvn test
+```
+mvn test
+```
 ## To run the test:
 
 ```
-javac src/*.java
-java -cp src Main
+cd src
+javac main/java/customer/*.java main/java/movie/*.java main/java/rental/*.java Main.java
+java Main
 ```

pom.xml

@@ -0,0 +1,37 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>com.example</groupId>
+    <artifactId>refactoring-java</artifactId>
+    <version>1.0-SNAPSHOT</version>
+
+    <properties>
+        <maven.compiler.source>15</maven.compiler.source>
+        <maven.compiler.target>15</maven.compiler.target>
+        <junit.version>5.7.0</junit.version>
+    </properties>
+
+    <dependencies>
+        <!-- JUnit 5 dependency -->
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-engine</artifactId>
+            <version>${junit.version}</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+
+    <build>
+        <plugins>
+            <!-- Maven Surefire Plugin for running tests -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>2.22.2</version>
+            </plugin>
+        </plugins>
+    </build>
+</project>
+

src/Main.java

@@ -1,16 +1,21 @@
+import main.java.movie.InMemoryMovieRepository;
+import main.java.movie.MovieRental;
+import main.java.rental.RentalCalculator;
+import main.java.rental.RentalStatementGenerator;
+import main.java.customer.Customer;
 import java.util.Arrays;
 
 public class Main {
 
   public static void main(String[] args) {
-    String expected = "Rental Record for C. U. Stomer\n\tYou've Got Mail\t3.5\n\tMatrix\t2.0\nAmount owed is 5.5\nYou earned 2 frequent points\n";
+    InMemoryMovieRepository movieRepository = new InMemoryMovieRepository();
+    RentalCalculator rentalCalculator = new RentalCalculator();
+    RentalStatementGenerator statementGenerator = new RentalStatementGenerator(movieRepository, rentalCalculator);
 
-    String result = new RentalInfo().statement(new Customer("C. U. Stomer", Arrays.asList(new MovieRental("F001", 3), new MovieRental("F002", 1))));
+    String result = statementGenerator
+        .generateStatement(
+            new Customer("C. U. Stomer", Arrays.asList(new MovieRental("F001", 3), new MovieRental("F002", 1))));
 
-    if (!result.equals(expected)) {
-      throw new AssertionError("Expected: " + System.lineSeparator() + String.format(expected) + System.lineSeparator() + System.lineSeparator() + "Got: " + System.lineSeparator() + result);
-    }
-
-    System.out.println("Success");
+    System.out.println(result);
   }
-}
+}