Skip to content

Commit

Permalink
fix: Explicitly depend on fb_sysfs in fb_storage (#26)
Browse files Browse the repository at this point in the history
## Description

Explicitly includes `fb_sysfs` as part of the `fb_storage` cookbook.

## Context

When I tried spinning up a different VM type that uses NVMe-based storage, I noticed that chef was failing. After further debugging, I realized that in certain cases ([such as for NVMe devices](https://github.com/etsy/chef-cookbooks/blob/99b3e3abc9b42096c6450d9f84582d50aa8e2448/cookbooks/fb_storage/resources/format_devices.rb#L141)), `fb_storage` calls out to `fb_sysfs`. However, `fb_storage` never explicitly includes `fb_sysfs`, so by default it's not available and causes the chef run to fail.

## Testing Plan

I ran manual tests via Packer - to do this, I had to manually change the instance size to one that supports hyperdisks (I used `c3-standard-22`) and then manually attached a hyperdisk to the instance. When I added the explicit `depends fb_sysfs`, that solved the issue and `fb_storage` was able to format and mount the drive as expected.

## Other Considerations

I'm not sure what other implications this might have; Maybe there's a reason `fb_sysfs` wasn't included explicitly and this will cause failures with non-NVMe devices?
  • Loading branch information
russtaylor authored Jul 29, 2024
2 parents 4127c83 + 968b61a commit b774201
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cookbooks/fb_storage/metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
version '0.0.1'
supports 'centos'
depends 'fb_helpers'
depends 'fb_sysfs'

0 comments on commit b774201

Please sign in to comment.