Automatically create a build of Etterna compatible with OSX High Sierra #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off a second before merging this -- want to rebase it and tidy things up a bit. |
The version of OpenSSL the CI uses targets too recent a macOS version, resulting in it referencing the symbol ___chkstik_darwin, a stack-smashing protection function added to macOS's libSystem after High Sierra. This chang tells the GHA CI to build a version of Etterna (denoted Legacy) that references a custom Homebrew tap I created instead of the default OpenSSL homebrew tap. My tap just adds in the option when building OpenSSL that tells it to target an early macOS version :)
bluebandit21
force-pushed
the
fix/osx_high_sierra_openssl
branch
from
f40e3d5
to
03d2be3
Compare
|
Should be good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully,
Closes: #1186
-- I haven't been able to find anyone willing to help verify my fix, unfortunately (I pinged like all six people that have been known to ever encounter this problem).
That said, I checked the disassembly of the generated binary and it looks good?
--
___chkstk_darwinis definitely not present :D