Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL chat feature + Scroll Wheel Debounce option. #1318

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

CreoSm
Copy link

@CreoSm CreoSm commented Sep 3, 2024

This pr makes it so pressing insert to open the chat box in multiplayer will automatically select it for typing.

@CreoSm CreoSm changed the title QoL change to chat overlay keybind in multiplayer QoL chat feature + Scroll Wheel Debounce option. Sep 16, 2024
@CreoSm
Copy link
Author

CreoSm commented Sep 16, 2024

I decided to add the feature requested in #1319 but haven't used github enough to know how to create a seperate pr..

@bluebandit21
Copy link
Member

Hey @Vezxe :)

Take a look at https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow , it'll give a good overview of the workflow used for most open source projects, including this one.

The bit you're missing is the creation of a new feature branch per new thing you're working on, which would then let you make a PR for every different branch.

If you're interested/want more info/help, definitely feel free to ping me in the Etterna developer Discord server (https://discord.gg/ZqpUjsJ) anytime :D

Thanks for taking the effort here to learn something unfamiliar and contribute to the game! :)

@CreoSm
Copy link
Author

CreoSm commented Sep 17, 2024

Ahh thank you, I'm already in the discord server as Creo. If i create more pr requests I'll definitely remember to create a separate branch for different changes, so that this doesn't happen again

@poco0317 poco0317 merged commit 438b8b8 into etternagame:develop Sep 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants