Fix compat failures due to dependency updates (by honouring parent's dep versions) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using macrotest, to make output consistent, it is necessary to pin to a particular version of Nightly Rust. But of course usptream Nightly Rust changes, and that means that dependencies (of the macro package under test) may need to be updated upstream. Sometimes those updates aren't compatible with our pinned Nightly. Therefore, tests must run with pinned versions of the dependencies, not just pinned versions of the compiler. Without this, we can run into trouble, as seen here, for example: https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/issues/60 Borrow a trick from dtolnay's trybuild, which faces the same problem: copy the outer workspace's Cargo.lock into the synthetic crate. This influences Cargo's resolver sufficiently; but since we run without --locked, Cargo can still adjust the file as needed for the synthetic crate.
|
Published in 1.0.12. |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Cargo.lock from workspace root (if available)
When using macrotest, to make output consistent, it is necessary to pin to a particular version of Nightly Rust.
But of course usptream Nightly Rust changes, and that means that dependencies (of the macro package under test) may need to be updated upstream. Sometimes those updates aren't compatible with our pinned Nightly.
Therefore, tests must run with pinned versions of the dependencies, not just pinned versions of the compiler. Without this, we can run into trouble, as seen here, for example:
https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/issues/60
Borrow a trick from dtolnay's trybuild, which faces the same problem: copy the outer workspace's Cargo.lock into the synthetic crate. This influences Cargo's resolver sufficiently; but since we run without --locked, Cargo can still adjust the file as needed for the synthetic crate.