Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymQEMU tests and Dockefile #39

Closed
wants to merge 55 commits into from

Conversation

damienmaier
Copy link
Collaborator

The goal of this PR is to have an automated testing of SymQEMU that runs it on a known binary and checks that it outputs the expected results.

This is WIP but you can already check what I have.

For now this PR contains the script for running SymQEMU on a simple test program, and a Dockerfile that compiles SymQEMU and runs the test.

Instead of compiling SymCC during the image build, I think it makes more sense to rely on the existing docker image for SymCC and extract from it the needed .so file. This way, if the commands needed for compiling SymCC change in the future, only the Dockerfile of SymCC will need to be updated.

Copy link

Thank you for your interest in the QEMU project.

This repository is a read-only mirror of the project's repostories hosted
on https://gitlab.com/qemu-project/qemu.git.
The project does not process merge requests filed on GitHub.

QEMU welcomes contributions of code (either fixing bugs or adding new
functionality). However, we get a lot of patches, and so we have some
guidelines about contributing on the project website:
https://www.qemu.org/contribute/

@github-actions github-actions bot closed this Feb 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2024
@eurecom-s3 eurecom-s3 unlocked this conversation Feb 11, 2024
@aurelf
Copy link
Member

aurelf commented Feb 11, 2024

Sorry for the inconvenience, this was closed by a GH action that came from the merge of QEMU, and it seems that while I can unlock I cannot reopen the PR (it seems to be not possible: isaacs/github#361)
Can you redo a PR for this and #40 ?

@aurelf
Copy link
Member

aurelf commented Feb 11, 2024

Also it seems this PR is on top of #38 ? I thought of merging #38 once we have the tests, but maybe it's easier to merge #38 first?

@damienmaier
Copy link
Collaborator Author

We can do this one before #38, this is a mistake on my side, I will submit a new PR tomorrow

@aurelf
Copy link
Member

aurelf commented Feb 11, 2024

Instead of compiling SymCC during the image build, I think it makes more sense to rely on the existing docker image for SymCC and extract from it the needed .so file. This way, if the commands needed for compiling SymCC change in the future, only the Dockerfile of SymCC will need to be updated.

In fact in the future maybe we should get SymCC to push a docker image (to Docker Hub or GitHub Packages) and use that one, so we don't even recompile it here.

We can do this one before #38, this is a mistake on my side, I will submit a new PR tomorrow

Great, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants