Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming for descriptiveness #29

Merged
merged 13 commits into from
Sep 3, 2024
Merged

Renaming for descriptiveness #29

merged 13 commits into from
Sep 3, 2024

Conversation

annamariadziubyna
Copy link
Collaborator

In this new version, we have made several updates to improve the codebase:

  • Removed MpsAnnealing: The MpsAnnealing structure has been completely removed.
  • beta is now a scalar: The beta parameter has been changed from vector form to a scalar.
  • Renaming: We've made additional changes to names throughout the code to ensure they are more descriptive and intuitive.
  • Args to kwargs conversion: Continued conversion of function arguments (args) to keyword arguments (kwargs) for better clarity and usage.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10236145432

Details

  • 54 of 83 (65.06%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 75.187%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util.jl 0 1 0.0%
src/search.jl 11 14 78.57%
src/contractor.jl 23 48 47.92%
Files with Coverage Reduction New Missed Lines %
src/contractor.jl 5 66.8%
Totals Coverage Status
Change from base Build 10213522947: 0.06%
Covered Lines: 1306
Relevant Lines: 1737

💛 - Coveralls

@annamariadziubyna
Copy link
Collaborator Author

Hi, I wanted to kindly ask if there has been any progress on reviewing the pull request I submitted. Once the pull request is merged into the master branch, you can proceed with resolving the two issues I raised to ensure they're aligned with the latest changes. Thank you!

@lpawela lpawela merged commit 129dc19 into master Sep 3, 2024
1 of 2 checks passed
@lpawela lpawela deleted the master_tobe branch September 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants