Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHS Built-up Surface #309

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

FedericoRondoni
Copy link

No description provided.

@lubojr
Copy link
Member

lubojr commented Oct 30, 2023

@Dorothyrono @jonasViehweger Could we please have your review and merge? Thanks!

Supersedes #295

@Dorothyrono Dorothyrono requested review from Dorothyrono and jonasViehweger and removed request for Dorothyrono November 3, 2023 07:32
BandInformation: GHS_BUILT_S
Contact: "[JRC](mailto:[email protected])"
Provider: "[JRC](https://ghsl.jrc.ec.europa.eu/)"
ManagedBy: "[JRC](https://ghsl.jrc.ec.europa.eu/)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed by is usually whoever added this data to the datacube, not the original data provider which is given in Provider. Please change that in all the yamls. I did some structural fixes but otherwise if this is changed it should be good!

Dorothyrono
Dorothyrono previously approved these changes Nov 8, 2023
@Dorothyrono Dorothyrono dismissed their stale review November 8, 2023 10:06

approved by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants