Fix workflow

europeana · Apr 3, 2024 · 22847fe · 22847fe
1 parent 38faabc
commit 22847fe
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/.github/workflows/deploy-image.yaml b/.github/workflows/deploy-image.yaml
@@ -1,7 +1,5 @@
 name: '- helper (image deployment)'
 on: workflow_call
-#env:
-#  APP_IMAGE: europeana/statistics-dashboard:${{ github.event.inputs.tag_name || 'develop' }}
 jobs:
   deploy-image:
     runs-on: ubuntu-latest
@@ -18,7 +16,6 @@ jobs:
       - run: |
           mv env_file/env_file deployment/${{ github.event.inputs.deploy_environment }}
 
-
       - run: |
           tag=${{ github.event.inputs.tag_name || 'develop' }}
           TAG_ESCAPED=${tag//[\/]/_}
@@ -31,18 +28,10 @@ jobs:
           tokenSuffix: '}#'
           files: '["deployment/${{ github.event.inputs.deploy_environment }}/*.yaml"]'
         env:
-          #APP_IMAGE: ${{ env.APP_IMAGE }}
-          #APP_IMAGE:  ${{ env.TAG_ESCAPED }}
           APP_IMAGE: europeana/statistics-dashboard:${{ env.TAG_ESCAPED }}
-
           MAX_REPLICAS: '4'
           MIN_REPLICAS: '2'
           UTILISATION_AVERAGE_PERCENT: '75'
-      - run: |
-          ls -l deployment/${{ github.event.inputs.deploy_environment }}
-          echo TAG_ESCAPED ${{ env.TAG_ESCAPED }}
-      - run: cat deployment/${{ github.event.inputs.deploy_environment }}/deployment.yaml
-      - run: cat deployment/${{ github.event.inputs.deploy_environment }}/hpa.yaml
 
       - name: Install IBM Cloud CLI
         run: |

diff --git a/.github/workflows/node.js.yaml b/.github/workflows/node.js.yaml
@@ -67,8 +67,6 @@ jobs:
           node-version: '18.18.0'
       - run: npm install
       - run: npm run dist-localised
-
-      #- run: mkdir tmp-dir && mv dist tmp-dir/ && mv tmp-dir dist
       - uses: actions/upload-artifact@master
         with:
           name: dist

diff --git a/.github/workflows/run-sonar.yaml b/.github/workflows/run-sonar.yaml
@@ -30,4 +30,3 @@ jobs:
             -Dsonar.sources=src/app
             -Dsonar.exclusions=src/**/_mocked/**
             -Dsonar.javascript.lcov.reportPaths=./lcov.info/lcov.info
-          #-Dsonar.javascript.lcov.reportPaths=lcov.info