Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize version numbers and use App::RewriteVersion in tooling #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Grinnz
Copy link

@Grinnz Grinnz commented Jun 5, 2018

Fixes #303

  • dist_version doesn't need to be specified in Build.PL, Module::Build can retrieve it from dist_version_from (which will default to lib/perl5i.pm based on the module_name).
  • the 'use version' and explicit version object construction isn't necessary on 5.10+ where version.pm is core. also, App::RewriteVersion can't rewrite those anyway
  • App::RewriteVersion does not support underscore versions in tuples. This is by design, because these are pretty crazy and you would need to depend on version.pm 0.9915 to get consistent behavior for them. App::RewriteVersion can pass a 'is_trial' option to rewrite_versions, but that will only append a # TRIAL comment to the version declarations, assuming you will mark the release as a trial yourself. (you can do this by adding -TRIAL to the tarball name just before the file extension, and by setting a release_status other than stable.)
  • Module::Build unfortunately has no built in way to specify App::RewriteVersion as a develop prereq, but the error message should hopefully make it apparent when it's needed.
  • changed admin shebangs because my perl is not in /usr/bin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant