Compile error after braking change in pkg/errors #74
Comments
arcana261
pushed a commit
to arcana261/logrus_sentry
that referenced
this issue
Jan 5, 2019
… github.com/pkg/errors See [Issue](evalphobia#74)
|
Is pkg/errors#188 related to this? |
|
@mexisme Yes dear good sir.. |
|
@arcana261 Thanks 🍡 #75 has been Merged. |
davecheney
added a commit
to pkg/errors
that referenced
this issue
Jan 9, 2019
Updates aws/aws-xray-sdk-go#77 Updates evalphobia/logrus_sentry#74 Go 1.12 has updated the behaviour of runtime.FuncForPC so that it behaves as it did in Go 1.11 and earlier. This allows errors.Frame to return to a uintptr representing the PC +1 of the caller. This will fix the build breakages of projects that were tracking HEAD of this package. Signed-off-by: Dave Cheney <[email protected]>
|
OMG They've done it again :'( :'( :'( |
|
I've again submitted another PR #76 which reverts us to using just PC's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hiiiiiii
Today a breaking change in
github.com/pkg/errorspackage was merged which changes type forerrors.Framefrom a simple program counter toruntime.Frame.github.com/evalphobia/logrus_sentry/sentry.go:314:16
cannot convert stFrames[i] (type "github.com/pkg/errors".Frame) to type uintptrI will work on a MR right away
The text was updated successfully, but these errors were encountered: