Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use runtime.Frame instead of program counters after braking change to github.com/pkg/errors #75

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

arcana261
Copy link
Contributor

@arcana261 arcana261 commented Jan 5, 2019

Apparently today, authors of github.com/pkg/errors have decided to pull off a breaking change in which they replace using PC's as type errors.Frame and use runtime.Frame as type errors.Frame. This PR fixes this issue by using runtime.Frames instead of program counters.

See Issue

@arcana261
Copy link
Contributor Author

@evalphobia errr my CI fails due to some thing irrelevant to my change made. Apparently we had to skip one more level of stacktrace.

I think it's related to this!

sirupsen/logrus#863

Why everyone has to do breaking changes.. stop this already :'(

…/logrus

Apparently due to this [merge request](sirupsen/logrus#863)
another level to stacktrace was introduced. So if we intend to skip it
by default we have to increase default number of skips in our
configuration.
@arcana261
Copy link
Contributor Author

I've added another commit :'( Since we have breaking change in 2 libraries I think we won't be able to make it through using 2 sperate PR's :'(

@arcana261
Copy link
Contributor Author

Just as clarification.. apparently this:

func (logger *Logger) Error(args ...interface{}) {
	if logger.IsLevelEnabled(ErrorLevel) {
		entry := logger.newEntry()
		entry.Error(args...)
		logger.releaseEntry(entry)
	}
}

was changes to this..

func (logger *Logger) Error(args ...interface{}) {
	logger.Log(ErrorLevel, args...)
}

which means we had to increase our Skip config! duh!

@evalphobia evalphobia merged commit af3520b into evalphobia:master Jan 9, 2019
@evalphobia
Copy link
Owner

Thank you! 🌱

Nite: https://github.com/evalphobia/logrus_sentry/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants