-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added solarman provider and template for deye-hybrid-3p-solarman #16067
Conversation
Great PR, thank you! This is a lot of code and added complexity. I'm not convinced yet that we should add this. Are these devices wide-spread? Are there any alternative solutions like HA modules or similar? Regarding choice of implementation: while a provider is a working approach- shouldn't this rather be a meter type instead? Is it absolutely necessary to duplicate such a large amount of modbus code? |
I would be in favour of it. The Deye is relatively sensitive with regard to the RTU mode. An identical manufacturer is Sunsynk, for example. I didn't know a solution with Home Assistant and Solarman |
Thank you for your feedback. The question whether it should be implemented as a meter or a provider, it is true that the data logger sticks are only used for inverters. From what I know no other devices use this way of communication. Therefore I guess it should be a meter. Anyhow I will try to find a solution to avoid the large amount of duplicated code. |
Just thinking loud:
is there any chance we could use ModbusRTU/TCP as underlying protocol and wrap that in a meter implementation (instead of reimplementing the entire modbus stack)? If not: could we potentially (not sure this would technically be better) add something like a ModbusSolarMan |
Can they been integrated any other way than an implementation in evcc? |
… Message ID: ***@***.***>
|
@PeterPablo what do you mean- that integration is already available? |
I had a look how the underlying client from grid-x implements the communication variants. I think I found here a way that I can also implement a client by using their interfaces. In my opinion I have to implement something like this for the solarman protocol.
I think he just wanted to emphasize that the lsw-3/solarman devices exists but are not implemented yet. |
Not if you make the result a meter or just its own type. Lets see how it looks when the basic interface is implemented. |
Closing until updated |
I've added a new provider for the solarman protocol which is used by the LSW-3 data logger. The protocol description can be found here. In general it is modbus with a layer on top. Unfortunately I had to copy a lot from the modbus provider as I didn't want to add this provider into the modbus provider. Maybe there might be a more elegant way. I also appreciate some feedback as I recently started developing in golang.
I'll add a PR to update the documentation later