Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM2GO Home: Workaround for old fw current and phase setting #16201

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

dniakamal
Copy link
Contributor

We would like to you to consider the following PR as a workaround for the EM2GO Home charger to address the following issues:

The workaround should only apply, if the firmware is <1.3 which will be tested by sending a current setting of 6.1A to the charger. If the returned value is 6A, the firmware is <1.3. If the returned value == 6.1A then it is assumed, that the firmware is >=1.3.

@RenatusRo
Copy link
Contributor

Does this
If the returned value == 6.1A
implicitly imply that the box can control the current in 100mA steps now?

@dniakamal
Copy link
Contributor Author

Does this If the returned value == 6.1A implicitly imply that the box can control the current in 100mA steps now?

Yes that is correct, but not with the old fw version.

@RenatusRo
Copy link
Contributor

Then there should probably be two different templates for the Home
to correctly reflect the "mA" capability depending on the FW version?
https://github.com/evcc-io/evcc/blob/master/templates/definition/charger/em2go-home.yaml

@dniakamal
Copy link
Contributor Author

dniakamal commented Sep 20, 2024

Then there should probably be two different templates for the Home to correctly reflect the "mA" capability depending on the FW version? https://github.com/evcc-io/evcc/blob/master/templates/definition/charger/em2go-home.yaml

For this purpose, we are setting "mA" capability in the charger golang file if the new firmware is installed:
`

if chargerCurrent == 6 {
	wb.workaround = true // Old FW installed
} else {
	wb.workaround = false // New FW installed
	maxCurrent = wb.maxCurrentMillis // This is setting "mA" capability
}

`

@RenatusRo
Copy link
Contributor

which is nice.
but only a template can fix the documentation at
https://docs.evcc.io/docs/devices/chargers#em2go
otherwise the Home won't be listed as mA capable
which might be a major selling point - not my business though :-)
people use the https://docs.evcc.io/docs/devices/chargers for their buying decisions ...

@njd1893
Copy link

njd1893 commented Sep 20, 2024

which is nice. but only a template can fix the documentation at https://docs.evcc.io/docs/devices/chargers#em2go otherwise the Home won't be listed as mA capable which might be a major selling point - not my business though :-) people use the https://docs.evcc.io/docs/devices/chargers for their buying decisions ...

Agree. That's how I found the EM2GO Home in the first place.

@dniakamal
Copy link
Contributor Author

which is nice. but only a template can fix the documentation at https://docs.evcc.io/docs/devices/chargers#em2go otherwise the Home won't be listed as mA capable which might be a major selling point - not my business though :-) people use the https://docs.evcc.io/docs/devices/chargers for their buying decisions ...

Agree. That's how I found the EM2GO Home in the first place.

Very well. We have added mA capability in the template and set mA support in the charger when not using the workaround.
We keep two templates, em2go and em2go-home for now, for compatibility reasons where existing users are using the "em2go-home" template in their evcc.yaml.

}
}

if _, err := wb.conn.WriteMultipleRegisters(em2GoRegPhases, 1, b); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that not better be placed before enabling again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that not better be placed before enabling again?

In general you are right, but the chargers old fw is always starting with 3p, even if we send the command in the first place. That´s why we first need to enable it, then set the phases, This is happening within 60ms, so it should not be an issue for the EV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants