Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with a missing paramter? #55

Open
HarelM opened this issue Jul 22, 2021 · 5 comments
Open

Problem with a missing paramter? #55

HarelM opened this issue Jul 22, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@HarelM
Copy link

HarelM commented Jul 22, 2021

I'm trying to upload a file to play store and I'm getting the following error:

npx apkup upload -k ./playstore_service_account.json -a $aabVersioned -t 'internal'
- Uploading APK...
ERROR: Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true. Once committed, the changes in this edit can be sent for review from the Google Play Console UI.

Is there a problem with my code? this used to work in the past... probably a change in google store API?

@nprail
Copy link
Member

nprail commented Jul 22, 2021

@HarelM Could you please run it again but set the DEBUG variable to this first:

export DEBUG=apkup:*

Then send the log from that.

I've not seen this error message before. It's possible that it is either an API change (although, I think unlikely) or your app is in some state that has different requirements.

@nprail
Copy link
Member

nprail commented Jul 22, 2021

This may be helpful: Triple-T/gradle-play-publisher#956 (comment)

@HarelM
Copy link
Author

HarelM commented Jul 22, 2021

Seems like the root cause sound similar as I recently got my app rejected (not sure why) and it might be that it's the same. The solution there seems like a good solution to me as well...
If this could be implemented here as well it would be great.
Thanks for this awesome library and the super quick response!

@acedigibits
Copy link

Any update on this issue ? How to send the query parameters ?

@ivictbor
Copy link

Hey guys, I implemented --changesNotSentForReview switch which fixes the issue.

Hey @nprail , great work here. I created PR for this key #69

If Noah will not be able to merge then everyone can use our scoped version:

npx @devforth/apkup \
  upload \
  --changesNotSentForReview \
  --track 'internal' \
  --key ~/keys/XXYYUUII.json \
  --apk build/app/outputs/bundle/release/app-release.aab \
  --release-notes "en-US=New Version $versionName: $1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants