Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for changesNotSentForReview to be able to upload apps in process of review in newer versions play console API #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivictbor
Copy link

No description provided.

@ivictbor ivictbor changed the title Support for changesNotSentForReview to be able to upload apps in process of review in newer versions play console of API Support for changesNotSentForReview to be able to upload apps in process of review in newer versions play console API Jun 21, 2022
@ivictbor
Copy link
Author

Not sure why Travis CI fails, locally it seams to be ok:

image

@nprail
Copy link
Member

nprail commented Jun 27, 2022

Thanks for the PR!

The Google APIs library has some odd type issues. I'll take a look at that and see if I can solve it.

Could you change the documentation on the parameter to what the parameter actually does rather than what problem it solves?

@ivictbor
Copy link
Author

@nprail Thanks for your response and handy package!

I made it after I faced this issue #55

To reproduce it you can create any dummy app e.g. using flutter bootstrapper, promote release to all possible levels in play console, request a review from console, and while they will review it try to publish it from apkup.

About doc: yep, I also don't like how I described it, sounds unusual, but thing is that I have no info and was not able to find it in API spec quckly, error just said ERROR: Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true so I just did it 🤷‍♂️

@ivictbor
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants