feat: Iterator for single shard in the tree #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
force-pushed
the
feat/scan-tree
branch
from
c5333e3 to
00fa47f
Compare
evenyag
force-pushed
the
feat/scan-tree
branch
from
4ff4ddb to
8150aa7
Compare
v0y4g3r
reviewed
Feb 7, 2024
| } | ||
|
|
||
| /// Converts current [RecordBatch] to [Batch]. | ||
| fn convert_current_record_batch( |
There was a problem hiding this comment.
This PR provides a DataBatch::as_record_batch method:
https://github.com/evenyag/greptimedb/pull/15/files#diff-5066fcdd3b887926278b1155cfbf005cbca27e9699e36292abcc55ecf80110e2R61-R63
There was a problem hiding this comment.
Slicing the record batch is a bit wasteful as it clones the underlying Vec<ArrayRef>. The data iter also has this issue as it has to clone the record batch for each pk index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the iterator ShardIter to scan a single shard in the merge tree.
Checklist
Refer to a related PR or issue link (optional)