Merge pull request #2164 from ever-co/2163-fix-deepscan-linting-issue…

…s-in-full-app

fix(DeepScan): fix the regex and unused imports and conditional rende…

apps/extensions/components/popup/Tasks.tsx

@@ -1,6 +1,5 @@
 import classNames from 'classnames';
-import React, { useEffect, useRef, useState } from 'react';
-import { act } from 'react-dom/test-utils';
+import React, { useEffect, useState } from 'react';
 
 import AppDropdown from '~components/shared/AppDropdown';
 import { roundInput, textEllipsis } from '~misc/tailwindClasses';
@@ -135,7 +134,8 @@ const Tasks: React.FC<Props> = ({ port }) => {
 							'ml-2 bg-slate-900 text-white rounded p-2',
 							isEmptyEstimate() && 'bg-slate-600'
 						)}
-						onClick={addNewTask}>
+						onClick={addNewTask}
+					>
 						Add Task
 					</button>
 				)}

apps/extensions/components/popup/Timer.tsx

@@ -1,7 +1,6 @@
 import classNames from 'classnames';
 import React, { useEffect, useState } from 'react';
 
-import browser from '~misc/browser';
 import { MessageTypesFromBackgroundEnum, MessageTypesToBackgroundEnum } from '~typescript/enums/MessageTypesEnum';
 import { TimerStateEnum } from '~typescript/enums/TimerStateEnum';
 import type { IPostMessage } from '~typescript/interfaces/PostMessage';

apps/extensions/popup.tsx

@@ -7,10 +7,7 @@ import Timer from '~components/popup/Timer';
 import './style.css';
 
 import browser from '~misc/browser';
-import { MessageTypesFromBackgroundEnum } from '~typescript/enums/MessageTypesEnum';
-import { TimerStateEnum } from '~typescript/enums/TimerStateEnum';
-import { IPostMessage } from '~typescript/interfaces/PostMessage';
-import { ITimerUpdate } from '~typescript/interfaces/TimerUpdate';
+
 
 function IndexPopup() {
 	const [port, setPort] = useState<chrome.runtime.Port | null>(null);

apps/mobile/app/components/Icon.tsx

@@ -53,7 +53,7 @@ export function Icon(props: IconProps) {
 	} = props;
 
 	const isPressable = !!WrapperProps.onPress;
-	const Wrapper: ComponentType<TouchableOpacityProps> = WrapperProps?.onPress ? TouchableOpacity : View;
+	const Wrapper: ComponentType<TouchableOpacityProps> = WrapperProps && WrapperProps?.onPress ? TouchableOpacity : View;
 
 	return (
 		<Wrapper

apps/mobile/app/helpers/regex.ts

@@ -5,4 +5,4 @@ export const VALID_HEX_COLOR = /^#(?:[0-9a-fA-F]{3,4}){1,2}$/;
 export const PHONE_REGEX = /^[\+]?[(]?[0-9]{3}[)]?[-\s\.]?[0-9]{3}[-\s\.]?[0-9]{4,6}$/;
 
 export const URL_REGEX =
-	/^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()!@:%_\+.~#?&\/\/=]*)$/;
+	/^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()!@:%_\+.~#?&\/=]*)$/;

apps/web/app/helpers/regex.ts

@@ -5,4 +5,4 @@ export const VALID_HEX_COLOR = /^#(?:[0-9a-fA-F]{3,4}){1,2}$/;
 export const PHONE_REGEX = /^[+]?[(]?[0-9]{3}[)]?[-\s.]?[0-9]{3}[-\s.]?[0-9]{4,6}$/;
 
 export const URL_REGEX =
-	/^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()!@:%_+.~#?&//=]*)$/;
+	/^https?:\/\/(www\.)?[-a-zA-Z0-9@:%._+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()!@:%_+.~#?&/=]*)$/;

apps/web/app/hooks/auth/useAuthenticationPasscode.ts

@@ -78,7 +78,7 @@ export function useAuthenticationPasscode() {
 					return;
 				}
 
-				if (data?.workspaces && data.workspaces.length) {
+				if (data && Array.isArray(data.workspaces) && data.workspaces.length > 0) {
 					setWorkspaces(data.workspaces);
 
 					setScreen('workspace');

apps/web/app/hooks/features/usePublicOrganizationTeams.ts

@@ -71,7 +71,7 @@ export function usePublicOrganizationTeams() {
 				}
 
 				let responseTasks = (res.data.tasks as ITeamTask[]) || [];
-				if (responseTasks && responseTasks.length) {
+				if (Array.isArray(responseTasks) && responseTasks.length > 0) {
 					responseTasks = responseTasks.map((task) => {
 						const clone = cloneDeep(task);
 						if (task.tags && task.tags?.length) {

apps/web/app/services/client/api/public-organization-team.ts

@@ -26,7 +26,7 @@ export function getPublicOrganizationTeamsAPI(profile_link: string, team_id: str
 		params[`relations[${i}]`] = rl;
 	});
 
-	const queries = qs.stringify(params || {});
+	const queries = qs.stringify(params);
 
 	const endpoint = GAUZY_API_BASE_SERVER_URL.value
 		? `/public/team/${profile_link}/${team_id}?${queries}`
@@ -48,7 +48,7 @@ export function getPublicOrganizationTeamsMiscDataAPI(profile_link: string, team
 		params[`relations[${i}]`] = rl;
 	});
 
-	const queries = qs.stringify(params || {});
+	const queries = qs.stringify(params);
 
 	const endpoint = GAUZY_API_BASE_SERVER_URL.value
 		? `/public/team/${profile_link}/${team_id}?${queries}`

apps/web/app/services/server/requests/public-organization-team.ts

@@ -58,7 +58,7 @@ export function getPublicOrganizationTeamMiscDataRequest({
 		params[`relations[${i}]`] = rl;
 	});
 
-	const queries = qs.stringify(params || {});
+	const queries = qs.stringify(params);
 
 	return serverFetch<IOrganizationTeamWithMStatus>({
 		path: `/public/team/${profileLink}/${teamId}?${queries.toString()}`,

apps/web/lib/features/team-members.tsx

@@ -25,7 +25,7 @@ export function TeamMembers({ publicTeam = false, kanbanView: view = IssuesView.
 	const orderedMembers = [...members].sort((a, b) => (sortByWorkStatus(a, b) ? -1 : 1));
 
 	const blockViewMembers =
-		activeFilter == 'all' ? orderedMembers : orderedMembers.filter((m) => m.timerStatus === activeFilter) || [];
+		activeFilter == 'all' ? orderedMembers : orderedMembers.filter((m) => m.timerStatus === activeFilter);
 
 	const currentUser = members.find((m) => m.employee.userId === user?.id);
 	const $members = members