-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/table view for issues #1648
Conversation
Update .env.sample
@evereq what do you suggest here? |
Also @YehualashetGit it is not loading data for me. |
|
@YehualashetGit / @badalkhatri0924 I think issue was probably that feature branch was created from |
apps/web/app/constants.ts
Outdated
@@ -116,3 +116,9 @@ export const APPLICATION_LANGUAGES_CODE = [ | |||
'ru', | |||
'es' | |||
]; | |||
|
|||
export enum KanbanView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YehualashetGit Maybe let's rename this to "IssuesView"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I will rename that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, I think values should be:
CARDS, TABLE, and BLOCKS, please adjust @YehualashetGit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
@@ -225,9 +225,9 @@ export function InviteUserTeamCard({ | |||
<DraggerIcon className="fill-[#CCCCCC] dark:fill-[#4F5662]" /> | |||
</div> | |||
|
|||
<div className="absolute opacity-40 right-2"> | |||
{/* <div className="absolute opacity-40 right-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YehualashetGit why this got commented out? Not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we don't need this code s actually, basically the invite row won't have such menu , may be i will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense @YehualashetGit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YehualashetGit On the other hand, idea was to make that Invite row to look similar to other rows... Iike it's still "empty" but when you invite someone that person will be shown there with task and other info... So I would prefer you to restore it back :)))
Also in the future when you removing something (even if it looks like not used), please state it in the PR explicitly - we should be very careful with remove things if we not sure about initial idea why it was added etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay understood , the main reason why I removed it was , there was no real data to display and they are just a place holder , that's why , but will reverted it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evereq is this a temporary or it only be visible on Table view cause ,it'll now make me to add more logic on TeamMeberTable View component to the invite row with separate actions
@YehualashetGit see my comments and let's fix this quickly so we can merge as soon as possible, thanks! So we will merge this and you will work to make 3rd view for the same data (block view), but essentially we will need to also work on a real "issues" page later. Let's discuss that later in Slack, for now let's finish this PR merge it, and create a "block" view next (from our Figma): |
@YehualashetGit there are some UI issues |
@YehualashetGit UI issue. |
@YehualashetGit you working on fixes for those issues right? |
yes I've fixed the ui issues |
@badalkhatri0924 can you review again please? If something still broken try to quick fix yourself and let's merge this one so I can review it online |
@YehualashetGit I merged with "squash", so please don't use anymore that same branch, create a new one based on develop for all future work on those tasks. Thanks! |
https://www.veed.io/view/f1ebbac3-64a1-4423-8e96-05685b3ea2b6?panel=share