Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/api calls post requests #1946

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

desperado1802
Copy link
Contributor

No description provided.

@desperado1802 desperado1802 self-assigned this Dec 3, 2023
organizationId: user?.employee.organizationId as string,
teamId: activeTeamId as string
},
user?.tenantId as string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desperado1802 can we add tenantId also in the object?

tenantId: string;
}
) {
console.log('Post Request:', endpoint, data, isDirect, extras);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove consoles/commented code from the PR.

@evereq
Copy link
Member

evereq commented Dec 4, 2023

@desperado1802 also needs to remove a lot of commented out code / console.log etc. After it's done is it ready to be merged?
CC: @badalkhatri0924

@badalkhatri0924
Copy link
Contributor

@desperado1802 also needs to remove a lot of commented out code / console.log etc. After it's done is it ready to be merged? CC: @badalkhatri0924

Yes we can merge as soon as those changes are done.

@desperado1802
Copy link
Contributor Author

@desperado1802 also needs to remove a lot of commented out code / console.log etc. After it's done is it ready to be merged? CC: @badalkhatri0924

Removed unnecesary commented code. We can merge @evereq
https://github.com/ever-co/ever-teams/assets/124465103/2cedf808-6d64-410d-a5bf-b76dafe0d5ed

@evereq evereq marked this pull request as ready for review December 4, 2023 15:59
@evereq evereq merged commit 434ce47 into develop Dec 4, 2023
10 of 12 checks passed
@evereq evereq deleted the improve/api-calls-post-requests branch December 4, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants