Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ReferenceSchema Event only when it match the schema #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afranzi
Copy link
Contributor

@afranzi afranzi commented Jan 14, 2019

This PR aims to report the ReferecenceSchema event only when the schema is matching against the event.

This PR aims to report the ReferecenceSchema event only when the schema is matching against the event.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.597% when pulling 526ea84 on afranzi:reference-schema into 6ed56f9 on everit-org:master.

@erosb
Copy link
Contributor

erosb commented Jan 14, 2019

Hi! This change can break existing behaviour (so it can break other users' visitors), can't it?

@afranzi
Copy link
Contributor Author

afranzi commented Jan 14, 2019

Yes, this change can break existing behaviour :(

The issue, is that json-schema is reporting the schema referenced even if the schema is not maching. Should we move to use the same approach of Match/UnMatch event with the Referent event?

So we can inform in the Listener if the Referenced Schema is matching or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants