Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds localization for the paypal module #431

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

awestbunk
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Labels in the paypal module are hardcoded in english language and therefore not localizable.

What is the new behavior?

This commit requires the translation utility and wraps all labels with the _('...') method. In addition it introduces a new translation file paypal.csv for the currently available languages (nl, it, de, zh)

Does this PR introduce a breaking change?

  • Yes
  • No

treoden and others added 2 commits January 7, 2024 10:26
@treoden treoden merged commit 567fe17 into evershopcommerce:main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants