access token generation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows seat to refresh an access token without making an esi call, for example for tokens that only have the
publicDatascope.Since I don't want to have a major release just for this, we can't modify the fetcher interface (that currently hold the access token refresh logic) and add a new method to refresh the access token. Therefore, I extracted all the access token refresh logic from the fetcher into a new AccessTokenRefresher class. The fetcher uses that to get access tokens.
The Eseye class itself doesn't implement an interface, so we can just add a method to refresh the access token in there. Internally, it also uses the AccessTokenRefresher