Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor env config and add new env var keys doc #37

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

hermesdj
Copy link
Contributor

In order to avoid commiting my own .env configuration to github, I needed to rename .env to .env.example and ignore the .env file in the gitignore. I think it is better to not have the basic .env file in the repository

I added the documentation for eseye env vars and app_locale.

@recursivetree
Copy link
Contributor

renaming .env to .env.example will break the installation instructions, you need to update the docs accordingly as well

@hermesdj
Copy link
Contributor Author

Yes I'm on it. For the install script it should not impact because it download .env.example and rename it immediately to .env so the rest of the script works as intended

@hermesdj
Copy link
Contributor Author

hermesdj commented Feb 3, 2024

I added a PR on the docs project : eveseat/docs#168

remove .idea
@Crypta-Eve Crypta-Eve merged commit 4b01bff into eveseat:5.0.x Apr 18, 2024
1 of 7 checks passed
Crypta-Eve added a commit that referenced this pull request Jun 12, 2024
* refactor env config

* added documentation on new env vars in .env.example

* fix bootstrap

* Update .gitignore

remove .idea

---------

Co-authored-by: Crypta Eve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants