add schedule seeder helper #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@joseph Null reported that his schedules get reset after restarting. This indeed seems to be the case: https://github.com/eveseat/eveapi/blob/5.0.x/src/database/seeders/ScheduleSeeder.php#L184-L187
Solution
On discord, we discussed that existing schedules shouldn't be changed, only missing ones inserted. While looking at this, I noticed that this happens for both eveapi and web. Their seeder are 99% identical in terms of logic for inserting schedules. Since plugins sometimes also need to schedule command, I decided it is worthy it to write a helper for this. This helper belongs in services as far as I know.