fix print preview in dark mode #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2970 |
zachstence
requested changes
Jan 13, 2025
packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/organisms/layout/EvidenceDefaultLayout.svelte
Outdated
Show resolved
Hide resolved
|
tried opening the preview - docs in a iframe on a local hosted site. print preview of dark mode in a iframe looks good.
Screen.Recording.2025-01-13.150948.mp4 |
zachstence
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures when in
Dark modeorSystem: Dark Modethat print preview will havelight modestylingScreen.Recording.2025-01-13.134631.mp4
Something I noticed that
system: dark modetakes care of print preview inlight mode, whilst keeping the page withdark modestyling. It would be ideal ifdark modedid the same, but couldn't find a way to make that happen.Checklist
[ ] I have added to the docs where applicable[ ] I have added to the VS Code extension where applicable