🧪 Test: more tests

[roninjin10]

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

• I read the contributing docs (if this is your first contribution)

Your ENS/address:

Summary by CodeRabbit

• New Features

  • Introduced the BlockReader contract for enhanced testing within the Ethereum Virtual Machine, featuring a getBlockInfo function.

• Bug Fixes

  • Improved error handling in the loadState function to ensure proper validation of parameters.
  • Fixed issues with block overrides missing a state root and improved handling of JSON-RPC procedures.
  • Enhanced client status management during mining operations to ensure accurate reporting.

• Tests

  • Added and modified multiple test cases to improve coverage for various functionalities, including block overrides, error handling, and state management.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
tevm-monorepo-tevm	⬜️ Ignored (Inspect)		Oct 1, 2024 6:25am

[changeset-bot]

🦋 Changeset detected

Latest commit: 6efcc7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@tevm/test-utils	Major
@tevm/actions	Major
@tevm/vm	Major
@tevm/ethers	Major
@tevm/viem	Major
@tevm/http-client	Major
@tevm/memory-client	Major
@tevm/node	Major
@tevm/server	Major
@tevm/state	Major
@tevm/cli	Major
@tevm/decorators	Major
tevm	Major
@tevm/txpool	Major
@tevm/evm	Major
@tevm/sync-storage-persister	Major
tevm-run	Major
@tevm/precompiles	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce several enhancements and bug fixes across various modules related to Ethereum transaction handling and testing utilities. A new BlockReader contract is added for testing block interactions, alongside multiple bug fixes in the @tevm/actions module, improving error handling and parameter validation. Additionally, various tests are introduced or modified to ensure robust coverage of the new functionalities and error scenarios.

Changes

Files	Change Summary
.changeset/fair-ghosts-rule.md	Introduced a new BlockReader contract for testing block interactions with a public view function getBlockInfo.
.changeset/grumpy-islands-sleep.md	Fixed a bug in the loadState function of @tevm/actions, improving parameter validation.
.changeset/mean-ghosts-wave.md	Addressed a bug in @tevm/actions and @tevm/vm related to missing state root during block overrides.
.changeset/tiny-dolls-enjoy.md	Fixed the tevm_call JSON-RPC procedure to correctly forward parameters like deployedBytecode.
.changeset/wild-bats-complain.md	Fixed client status management in the mining process to ensure accurate status reporting.
packages/actions/src/Call/callHandler.js	Enhanced error handling and control flow in the callHandler function, improving transaction handling.
packages/actions/src/Call/callHandlerOpts.js	Improved error handling for block retrieval and added a stateRoot property in block override logic.
packages/actions/src/Call/callHandlerResult.js	Enhanced handling of the evmResult object, adding more comprehensive checks and output structure.
packages/actions/src/Call/callProcedure.js	Expanded request handling in callProcedure to include additional parameters for calls.
packages/actions/src/Call/callProcedure.spec.ts	Added new test cases for block overrides and tracing in callProcedure.
packages/actions/src/Call/handleEvmError.js	Modified error handling logic in handleRunTxError function, removing a specific insufficient funds check.
packages/actions/src/Call/handleEvmError.spec.ts	Added a test case for handling insufficient balance errors.
packages/actions/src/Contract/contractHandler.spec.ts	Added a test case for handling contract revert errors.
packages/actions/src/Deploy/deployHandler.spec.ts	Introduced a test case for incorrect constructor arguments in deployHandler.
packages/actions/src/DumpState/dumpStateHandler.js	Added error handling logic and imported BaseError for better error management.
packages/actions/src/DumpState/dumpStateHandler.spec.ts	Added a test case for handling non-existent blocks in dumpStateHandler.
packages/actions/src/LoadState/loadStateHandler.spec.ts	Enhanced testing of loadStateHandler with new scenarios for error handling.
packages/actions/src/LoadState/validateLoadStateParams.js	Improved error handling for state validation errors.
packages/actions/src/Mine/mineHandler.js	Modified control flow and error handling in mineHandler to manage client statuses.
packages/actions/src/Mine/mineHandler.spec.ts	Added new test cases for various client statuses and error scenarios in mineHandler.
packages/actions/src/anvil/anvilDropTransactionProcedure.spec.ts	Introduced tests for the anvilDropTransactionJsonRpcProcedure, covering successful drops and error handling.
packages/actions/src/anvil/anvilDumpStateProcedure.spec.ts	Added tests for the anvilDumpStateJsonRpcProcedure, verifying state dumping functionality.
packages/actions/src/anvil/anvilGetAutomineProcedure.spec.ts	Created tests for the anvilGetAutomineJsonRpcProcedure, checking automining status.
packages/actions/src/eth/ethGetLogsHandler.spec.ts	Added a timeout configuration for a test case related to past blocks in forked mode.
packages/actions/src/eth/getCodeHandler.spec.ts	Enhanced testing coverage for getCodeHandler, including edge cases for non-existent addresses and block tags.
packages/actions/src/eth/utils/parseBlockParam.spec.ts	Refactored tests to use a real blockchain instance for handling block parameters.
packages/actions/src/internal/maybeThrowOnFail.spec.ts	Added a test case for the maybeThrowOnFail function when no errors are present.
packages/actions/src/requestBulkProcedure.js	Improved error handling for rejected requests in requestBulkProcedure.
packages/actions/src/requestBulkProcedure.spec.ts	Added tests for handling mixed successful and failed requests in requestBulkProcedure.
packages/actions/src/requestProcedure.spec.ts	Added test case for unsupported methods in requestProcedure.
packages/actions/vitest.config.ts	Updated Vitest configuration to generate coverage reports even on test failures.
packages/vm/src/actions/runTx.ts	Modified transaction execution logic, enhancing gas limit handling and error management.

Possibly related PRs

• ✨ Feat: Add deployHandler #1058: The introduction of the DeployHandler may relate to the BlockReader contract as both involve contract deployment and interaction within the Ethereum environment.
• 🧪 test: Add simpleContract to test utils (#1066) #1071: The addition of simpleContract to test utilities could be relevant as it may be used in conjunction with the BlockReader for testing purposes.
• 🐛 Fix: add support for incrementing nonces #1074: Changes related to transaction pools and nonces may connect with the BlockReader as it deals with block interactions and state management.
• 🐛 Fix: Fix issue with tx not being properly removed from mempool #1076: Fixes related to transaction management could be relevant as they may affect how the BlockReader interacts with transactions.
• ✅ Test: Add a bunch of viem api tests #1109: The addition of tests for the viem API may relate to the BlockReader as it could be used to validate block interactions.
• ✅ Test: Verify some test apis #1141: The addition of tests for the viem API could also relate to the BlockReader as it may involve block reading functionalities.
• 🧪 Test: Add wagmi test #1166: The test coverage for wagmi may connect with the BlockReader if it involves interactions with Ethereum blocks.
• 🥅 Feat: Good error messages #1186: Improvements in error messages may enhance the usability of the BlockReader when handling block-related errors.
• ♻️ Chore: Productionize vm package #1237: The productionization of the vm package may include enhancements that affect how the BlockReader operates within the Ethereum Virtual Machine.
• 🧪 Test: Add more procedures tests #1247: The addition of more tests for procedures may include tests that validate the functionality of the BlockReader.
• ✨ Feat: Implement final client api #1252: The implementation of the final client API may involve interactions with the BlockReader for block reading functionalities.
• ✅ Test: Add test coverage to unplugin #1273: The addition of test coverage to unplugin may relate to the BlockReader if it involves block interactions.
• 🧪 Test: Add more server tests #1277: The addition of more server tests may connect with the BlockReader if it involves server-side interactions with blocks.
• 🐛 Fix: eth_sendRawTransaction bug and more tests #1460: The fix for eth_sendRawTransaction may relate to how transactions are processed in conjunction with the BlockReader.
• 🧪 Test: Add more test coverage to actions #1466: The addition of more test coverage to actions may include tests that validate the functionality of the BlockReader.
• 🧪 Test: Add more test coverage to actions #1467: The enhancement of test coverage for actions may also involve testing the BlockReader functionalities.

🐰 In the land of code where rabbits play,
A BlockReader hops in, brightening the day!
With fixes and tests, the bugs are no more,
In Ethereum's realm, we leap and explore!
So let's celebrate this coding delight,
With hops and with joy, we code through the night! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[roninjin10]

• 🧪 Test: more tests #1469 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite