MinTtl should be optional. Fixes #226

evryfs · Apr 6, 2021 · 981dea3 · 981dea3
1 parent 3bab8a5
commit 981dea3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/api/v1alpha1/githubactionrunner_types.go b/api/v1alpha1/githubactionrunner_types.go
@@ -32,6 +32,7 @@ type GithubActionRunnerSpec struct {
 	MaxRunners int `json:"maxRunners"`
 
 	// Minimum time to live for a runner. This can avoid trashing by keeping pods around longer than required by jobs, keeping caches hot.
+	// +kubebuilder:validation:Optional
 	// +kubebuilder:default="0m"
 	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Minimum time to live"
 	MinTTL metav1.Duration `json:"minTtl"`

diff --git a/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml b/config/crd/bases/garo.tietoevry.com_githubactionrunners.yaml
@@ -3826,7 +3826,6 @@ spec:
             required:
             - maxRunners
             - minRunners
-            - minTtl
             - organization
             - podTemplateSpec
             type: object