Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context cancelled check #13

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

costela
Copy link
Member

@costela costela commented Dec 29, 2023

IgnoreContextCancellation would only work with bare errors and ignore wrapped ones. This should fix that.

Plus, we rename IgnoreContextCancellation to IgnoreContextCanceled: shorter and less ambiguous spelling 😉

BREAKING: also rename IgnoreContextCancellation to IgnoreContextCancelled
@costela costela force-pushed the leo.antunes/fix-context-cancelled-check branch from 30c36d9 to 297d457 Compare December 29, 2023 15:27
Copy link
Member

@obitech obitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costela costela merged commit 0ced27e into main Dec 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants