Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellinor cyrillic #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ellinor cyrillic #54

wants to merge 2 commits into from

Conversation

ellinor-rapp
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/virgil/6sru5F8DUBqmDTWTUyEawBFuiduT
✅ Preview: https://virgil-git-ellinorcyrillic-excalidraw.vercel.app

@thorn0
Copy link
Collaborator

thorn0 commented Mar 24, 2021

Looks good! I like most of the new glyphs. I see one real problem and have a couple of less important comments.

Problem: the uppercase "У" looks too much like "Ч". "У" can't look like this. When its longer line is vertical, it should have a tail curling to the left for the letter to be clearly distinguished from Ч. The red ones are У's, the blue one is Ч:

image

Note that this applies only to the upper case. The lowercase "у" has a descender below the baseline that distinguishes it from the lowercase "ч", which never has a descender.

Comments:

  • In a font where the lowercase д has a descender, it's expected that з should have it too
  • The uppercase Д is fine, but consider using the same shape that is used for the Latin D. That's how almost everyone writes it by hand. E.g. see here how children are taught to write it in school.
  • The mark above й could be a bit more curved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants